fix(http_requests): allow blob: to prepend URL string #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I signed it. (Looks like I have initiated the CLA, but not signed it until a few seconds ago) |
|
Does this actually work, though? It looks like it just discards the "blob:" prefix when parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR in this repo. Apologies if I have made any mistakes.
Currently, if the data source originates from the web (thus have the URL of
https?://), theparseUrlfunction correctly parses the protcol, host and path.In our usecase, we often need to download the entire (nifti) image, preprocess them, and generate a blob URL. According to mdn doc on
URL.createObjectURL, it creates a URL withblob:prepended. This fails the check as it is implemented currently.This PR addresses this issue.